Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and add a MongoDB schema (Issue 75) #100

Closed
wants to merge 9 commits into from

Conversation

Kannav02
Copy link
Collaborator

@Kannav02 Kannav02 commented Nov 19, 2024

This PR will add the MongoDB schema to support the feedback data that was being used with google sheets

The following additions were made

  • function allowing to connect to the MongoDB client were established
  • new .env.example file was made to provide an example of making MongoDB URI
  • functions allowing to manipulate the MongoDB instance have been made

Apart from this a minor bug fix was also done in the frontend/utils/feedback.py file, which allowed the right passing of parameters to the functions during the runtime to avoid unexpected errors

An example of when I tried to create a mongoDB instance is here , I got the collections and the database that were being created
Screenshot 2024-11-18 at 9 16 52 PM

This PR is one of many which would lead to a complete solution of issue #75

@luarss
Copy link
Collaborator

luarss commented Nov 19, 2024

Please signoff your commits @Kannav02. If you are successful, the Verified logo will appear beside your commits.

Example:
image

common/mongoClient.py Outdated Show resolved Hide resolved
common/mongoClient.py Outdated Show resolved Hide resolved
@Kannav02 Kannav02 force-pushed the issue-75-1 branch 2 times, most recently from df960a5 to 5c7de55 Compare November 20, 2024 01:58
@Kannav02
Copy link
Collaborator Author

Hey @luarss , i believe this should be good for review now, do let me know if you want any other changes to this

thank you

@luarss
Copy link
Collaborator

luarss commented Nov 20, 2024

Hi, can you please recreate the branch and PR directly from upstream and not the fork? I think there are some secrets not propagatable to forks.

@Kannav02
Copy link
Collaborator Author

Kannav02 commented Nov 20, 2024

I am trying to push my new branch to upstream, but it says I don't have the permission to do so, I believe this is because of the write access

remote: Permission to The-OpenROAD-Project/ORAssistant.git denied to Kannav02. fatal: unable to access 'https://github.com/The-OpenROAD-Project/ORAssistant.git/': The requested URL returned error: 403

@luarss
Copy link
Collaborator

luarss commented Nov 20, 2024

Do try again, given you access.

@Kannav02
Copy link
Collaborator Author

I believe you were right about the secrets not being able to propagate to the fork, this is quite interesting, I can look into this as well why it is happening if you want me to, as this might lead to each contributor needing to have write access to the repo before they can merge their changes

@luarss
Copy link
Collaborator

luarss commented Nov 20, 2024

That would be helpful. Thanks!

@luarss luarss closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants